Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird timing being shown in the performance bar on page navigation #25

Open
ur0 opened this issue Dec 6, 2015 · 3 comments · May be fixed by #35
Open

Weird timing being shown in the performance bar on page navigation #25

ur0 opened this issue Dec 6, 2015 · 3 comments · May be fixed by #35

Comments

@ur0
Copy link

ur0 commented Dec 6, 2015

I've installed Peek into my application, and this is what I've been getting.

bug

This happens only when you navigate to the page, i.e. if you open the page by URL or refresh the page, this doesn't seem to occur. I'm thinking of this as a turbolinks issue.

Any help?

@dewski
Copy link
Member

dewski commented Feb 3, 2016

Which browser is this on?

@hauleth
Copy link

hauleth commented Jun 24, 2016

For me this is on Chrome 51 on macOS El Capitan

@CHTJonas
Copy link

Just experienced this myself. I think it's related to Turbolinks as the problem went away when I disabled TL and then reappeared when I enabled...

glaszig added a commit to glaszig/peek-performance_bar that referenced this issue Apr 26, 2024
ajax timings are derived from `event.timeStamp` values. latest browser improvements in anti-fingerprinting measures made APIs return timestamps with reduced time precision. calculating timings with those values with `new Date().getTime()` will blow up because it returns a different precision value. the solution is to use `performance.now()` in place of `Date()`

https://developer.mozilla.org/en-US/docs/Web/API/Event/timeStamp
https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp
https://developer.mozilla.org/en-US/docs/Web/API/Performance/now

should resolve peek#33
should resolve peek#25
@glaszig glaszig linked a pull request Apr 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants