-
-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facing FPS issues in some android devices #1635
Comments
Hello, Are you using filters? This feature could reduce your fps. |
We are using custom filters but previously it maintained from 25 to 30. (This is a recent issue) And we are using camera2. |
What do you mean with recent issue? Do you have a library version working with better performance? |
before when we had the 2.0 series we didn't face any such fps issues, currently we are using 2.5.1 |
Please, test with version 2.5.0 and version 2.5.4 and let me know the result. In version 2.5.1 I did a refactor to camera2 and I did a fix to that in version 2.5.2. Maybe the error is related to that |
Changed the library version to 2.5.0, no changes. |
exactly, which version was working fine? |
In 2.1.9 it was working properly |
Hello, I did a branch for this case: implementation 'com.github.pedroSG94.RootEncoder:library:30658db922' This gradle use the camera2 code source of version 2.1.9 and should fix the problem. If the problem is not fixed we can assume that the problem is not related with that class and we should find the reason. |
Thank you for creating a gradle. |
Hello, I tested using a samsung A53 and a samsung tab A9+ but I'm not able to reproduce the problem. Can you tell me filters used? Also, remove filters to make sure that the problem is not related with the filters |
We used android view filter in our app and yes we noticed normal fps without using it. |
Hello, I did a fix in master. Can you check if it is working fine with camera2 using the last commit of master branch? implementation 'com.github.pedroSG94.RootEncoder:library:58ce357411' |
No we tried the gradle and the fps issue is still happening again in camera2. |
I see, I don't understand because in this version:
You are using Camera2ApiManager code of version 2.1.9 that worked for you. So, I think that the problem is not related with Camera2ApiManager in that devices. You mentioned that in the devices that still fail, if you remove the filter, it is working properly, right? |
When we are streaming a video in 720p we are setting the FPS to 30 but it is falling very low in some devices, and there is not sync in which it can detected. Some examples:
Any advice how to fix this ?
The text was updated successfully, but these errors were encountered: