Is MediaCodec.BufferInfo‘s size is length, not endIndex ?

[KittenBall]

https://github.com/pedroSG94/RootEncoder/blob/master/rtmp/src/main/java/com/pedro/rtmp/flv/audio/AacPacket.kt#L79

header[1] = Type.RAW.mark
buffer = ByteArray(info.size - info.offset + header.size)

byteBuffer.get(buffer, header.size, info.size - info.offset)

I think the correct code is

header[1] = Type.RAW.mark
buffer = ByteArray(info.size + header.size)
buffer.position(info.offset)
byteBuffer.get(buffer, header.size, info.size)

I have not test, let me know if I wrong, thank you !

[pedroSG94]

Hello,

You are right, but it is already done by MediaCodec class but maybe I should do it anyway for sanity.
I will need to apply this to all protocols and packets

[KittenBall]

Yes, most of time, MediaInfo's offset is 0, so this problem does not appear.

[pedroSG94]

This should be solved here:
#1344

[KittenBall]

Thank you very much.