Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jassert when inspecting multiline comment #4

Open
pckerneis opened this issue Oct 24, 2018 · 0 comments
Open

jassert when inspecting multiline comment #4

pckerneis opened this issue Oct 24, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@pckerneis
Copy link
Owner

Describe the bug
There's an assertion (jassert) in Debug mode when trying to inspect a comment name property with line breaks. The PropertyItemTextComponent's editor isn't set into multiline

To Reproduce
Steps to reproduce the behavior (in Debug mode)

  1. Create a comment element (right-click on the graph panel, Add..., Add comment)
  2. Type some multi-line text.
  3. If you select this comment alone, a jassert is triggered when updating the inspector panel.

Expected behavior
I think the best thing to do would be to allow multi-line text property components. But that would need some visual trickery as the first line of the property's value would begin with the parameter's name label. e.g.

value: "This is a multiline
text looking good"

We would need either to add some 'offset' to the first line of the value's TextEditor, or
having smart connected editors for each line (that sounds heavy for objects that may have thousands of copies for a session) or, the simplest solution (but not as much satisfying) : just add a line break before the value section e.g.

value:
"This is a multiline text
made easy"

Desktop (please complete the following information):

  • OS: OSX 10.13.6
  • Version: 0.0.1
@pckerneis pckerneis added the bug Something isn't working label Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant