You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The aggregate signals in lightpath_summary sometimes don't believe internal signals it holds onto are connected. We do ask that callbacks be run when we subscribe, but somewhere this isn't happening for InternalSignal
Expected Behavior
Internal signals should report themselves as connected
Context / environment
looking at sp1l0, which had its lightpath_summary not be connected.
Credit to @ZLLentz for debugging this live
Steps to Reproduce (for bugs)
Load sp1l0
sp1l0.connected = False
sp1l0.lightpath_summary.connected = False
[sig for sig in sp1l0.lightpath_summary._signals.values() if sig.connected] is empty
sp1l0.xtal_out._run_metadata_callbacks()
[sig for sig in sp1l0.lightpath_summary._signals.values() if sig.connected] is now not empty
Suggested Solution
Call ._run_metadata_callback at some point, ideally on subscribe (which should be happening...), or possible on init/set/get
The text was updated successfully, but these errors were encountered:
Current Behavior
The aggregate signals in lightpath_summary sometimes don't believe internal signals it holds onto are connected. We do ask that callbacks be run when we subscribe, but somewhere this isn't happening for
InternalSignal
Expected Behavior
Internal signals should report themselves as connected
Context / environment
looking at
sp1l0
, which had its lightpath_summary not be connected.Credit to @ZLLentz for debugging this live
Steps to Reproduce (for bugs)
Suggested Solution
Call
._run_metadata_callback
at some point, ideally on subscribe (which should be happening...), or possible on init/set/getThe text was updated successfully, but these errors were encountered: