Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent test failure from pcds-envs #113

Open
ZLLentz opened this issue Oct 27, 2022 · 0 comments
Open

Intermittent test failure from pcds-envs #113

ZLLentz opened this issue Oct 27, 2022 · 0 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Oct 27, 2022

Expected Behavior

Tests should always pass!

Current Behavior

See pcdshub/pcds-envs#253

_______________________________ test_basic_plans _______________________________

daq = <pcdsdaq.daq.Daq object at 0x7f3ed47a12b0>
RE = <bluesky.run_engine.RunEngine object at 0x7f3ed47a9e50>

    @pytest.mark.timeout(10)
    def test_basic_plans(daq, RE):
        logger.debug('test_basic_plans')
        daq.configure(events=12)

        start = time.time()
        RE(stage_wrapper(run_wrapper(trigger_and_read([daq])), [daq]))
        dt = time.time() - start
>       assert 0.1 < dt < 0.2
E       assert 0.20763921737670898 < 0.2

tests/test_daq.py:330: AssertionError

Possible Solution

  • Extend the range of acceptable timings
  • Make our timing check more accurate
  • Rework the test
  • Remove the test

Steps to Reproduce (for bugs)

  1. Run the test suite on a slow server

Context

Probably low priority. This adds some noise to the pcds-envs unit testing suite.

Your Environment

pcds-5.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant