Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Cleaning up DAQ/RE Interactions #100

Open
ZLLentz opened this issue Jan 15, 2021 · 0 comments
Open

Consider Cleaning up DAQ/RE Interactions #100

ZLLentz opened this issue Jan 15, 2021 · 0 comments

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Jan 15, 2021

Current Behavior

  • DAQ subscribes to the RE's doc stream to figure out that it needs to end a run when the RE's run ends
  • This involves a lot of gross logic that can fall apart
  • This creates confusing scenarios where certain bluesky plans can accidentally run multiple DAQ runs
  • This creates weird edge cases where only a special RE in a session can run a DAQ scan

Possible Solution

  • Replace auto run start/end with explicit daq.run_start_plan, daq.run_stop_plan
  • Include these in the nabs decorators

Steps to Reproduce (for bugs)

  1. Create a daq scan that does multiple plans from bluesky.plans
  2. Run it

Context

  • Common issue when creating more complex plans
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant