Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Screen Reference in motor-expert-screen #175

Open
slactjohnson opened this issue Feb 27, 2024 · 0 comments
Open

Dev Screen Reference in motor-expert-screen #175

slactjohnson opened this issue Feb 27, 2024 · 0 comments

Comments

@slactjohnson
Copy link
Contributor

The motor expert screen makes some odd references to old aerotech screens in Karl's directory (and apparently formerly Mike's directory) here: https://github.com/pcdshub/engineering_tools/blob/master/scripts/motor-expert-screen#L107-L109

It's not clear to me why we're using the old dev paths, and further more why aerotech is the fallback option here.

Possible Solution

The screen location should be updated to a released directory, and at the very least a comment added about the aerotech fallback.

Context

I was perturbed by this when reviewing an un-related PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant