New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Improve archive viewer error messages #197

Open

tangkong opened this issue Aug 15, 2023 · 0 comments

Contributor

tangkong commented Aug 15, 2023

Expected Behavior

Error messages should mean something to a human

Current Behavior

If a bad PV is provided, we get this error from the atef internals. We should improve handling in the case where PV data can't be found

Possible Solution

do some data validation, or actually catch exceptions

Steps to Reproduce (for bugs)

Open the archive viewer
Type any non-pv string into the search box and hit enter

Context

My own gratification, since apparently nobody's been using this viewer.

Your Environment

pcds-5.7.3, atef v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment