You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you make a branch in BEAMS, the github actions workflow will run.
If you make a PR in BEAMS, the github actions workflow will run.
If you make a PR of a branch in BEAMS, the github actions workflow will run twice and show up doubled in the PR.
This is because the (standard) github actions config we use has workflow triggers both on "push" and on "pull request".
If using only forks, the effect of the "push" workflow trigger is only ran on merges to master.
Here, since we're using local branches, we get to see double.
Expected Behavior
Workflows here should only run once each during a PR.
Learning from fixing this issue should be replaced in our templates/best practices.
Steps to Reproduce (for bugs)
Make a new branch in pcdshub/BEAMS
PR your branch into the default branch
Peek at your "checks" section.
Suggested Solution
I'm not entirely sure where to start here
The text was updated successfully, but these errors were encountered:
If we were forking properly, and as prescribed, this wouldn't be an issue. Realistically this is something we should fix in ci-helpers, I remember looking into this but not turning up a concise way to layer the triggers. I may be mistaken though
Current Behavior
If you make a branch in BEAMS, the github actions workflow will run.
If you make a PR in BEAMS, the github actions workflow will run.
If you make a PR of a branch in BEAMS, the github actions workflow will run twice and show up doubled in the PR.
This is because the (standard) github actions config we use has workflow triggers both on "push" and on "pull request".
If using only forks, the effect of the "push" workflow trigger is only ran on merges to master.
Here, since we're using local branches, we get to see double.
Expected Behavior
Workflows here should only run once each during a PR.
Learning from fixing this issue should be replaced in our templates/best practices.
Steps to Reproduce (for bugs)
Suggested Solution
I'm not entirely sure where to start here
The text was updated successfully, but these errors were encountered: