From f41d002bf70cd1ae5c5f9e19af850cea5260e3d7 Mon Sep 17 00:00:00 2001 From: Paulo Castello da Costa Date: Fri, 27 Dec 2024 09:38:52 -0800 Subject: [PATCH] Address review comments. --- tools/internal_ci/linux/grpc_e2e_performance_gke.sh | 4 ++++ .../internal_ci/linux/grpc_e2e_performance_gke_experiment.sh | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/tools/internal_ci/linux/grpc_e2e_performance_gke.sh b/tools/internal_ci/linux/grpc_e2e_performance_gke.sh index ebe1a35fb4e95..28e21baca9459 100755 --- a/tools/internal_ci/linux/grpc_e2e_performance_gke.sh +++ b/tools/internal_ci/linux/grpc_e2e_performance_gke.sh @@ -210,6 +210,10 @@ if [[ -v "useLanguage[ruby]" ]]; then fi # Disable broken tests by regex. +# The test disabled here hangs on 8 cores. The result of this test is not +# displayed in the public dashboard. The test runs and passes on the 30-core +# ("32core") node pool. This can be considered a permanent fix, selectively +# removing an unnecessary test and allowing the test run to become green. declare -a disabledTests8core=( cpp_protobuf_async_client_unary_1channel_64wide_128breq_8mbresp_insecure ) diff --git a/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh b/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh index 75cbf86fc4f9b..fea6d7514d4d8 100755 --- a/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh +++ b/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh @@ -205,6 +205,10 @@ if [[ -v "useLanguage[ruby]" ]]; then fi # Disable broken tests by regex. +# The test disabled here hangs on 8 cores. The result of this test is not +# displayed in the public dashboard. The test runs and passes on the 30-core +# ("32core") node pool. This can be considered a permanent fix, selectively +# removing an unnecessary test and allowing the test run to become green. declare -a disabledTests8core=( cpp_protobuf_async_client_unary_1channel_64wide_128breq_8mbresp_insecure )