Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NaN Safe Assert Statements #206

Open
kylekrol opened this issue May 6, 2020 · 1 comment
Open

Add NaN Safe Assert Statements #206

kylekrol opened this issue May 6, 2020 · 1 comment
Labels
bug Something isn't working gnc

Comments

@kylekrol
Copy link
Member

kylekrol commented May 6, 2020

Currently, some assert statements in GNC will fail on NaN inputs even when a NaN input is permissible. Adding some assert macro(s) that allows a NaN inputs would be helpful.

@kylekrol kylekrol added bug Something isn't working enhancement New feature or request labels May 6, 2020
@kylekrol kylekrol added gnc and removed enhancement New feature or request labels Jan 3, 2021
@kylekrol
Copy link
Member Author

This bug was moved into the critical category because it recently hindered our ability to run the attitude filter during eclipse in PSim standalone. Essentially, when the satellite goes into eclipse the sun sensor measurement is set to NaN. This causes assertions to fail in the gnc library.

Two things to note:

  1. The assertions should be fixed so we can run psim standalone with assertions present.
  2. We should also be able to build a "release" version of the Python module that excludes assertions for the sake of a performance boost. This, however, seems better tracked on Add a Mechanism for Debug and Release Builds #243.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gnc
Projects
None yet
Development

No branches or pull requests

1 participant