deploy - use tag as version #68
Conversation
drahnr
force-pushed
the
bernhard-deploy
branch
from
f750ace to
a6872cf
Compare
|
But this doesn't update the |
|
Well, we could inverse the relation. Make the manifest the truth and create a git tag after release (like |
|
This sounds much better to me.
Don't understand what you mean. It would make the tag to a fixed commit hash and also release this very ref. If someone pushes to master in-between this wouldn't matter. Was this your concern? |
Access rights for the github action to tag (aka write to the repo would be required) - that's usually not great since the action can be modified by contributors, hence not great. |
|
Aren't changes to github actions only executed once they are merged to master for this reason as a security measure (or at least you can enable that)? |
| uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: run | ||
| args: --release -- version set $(git tag --contains HEAD --format='%(refname)' | sd '^refs/tags/v([0-9]+\.[0-9]+\.[0-9]+(?:-[A-Za-z0-9]+(?:\.[0-9]+)?)?)$' '$1' ) |
There was a problem hiding this comment.
unleash already has git2 in its dependency tree and uses that. arguably, version set --git-tag might be something we want to support native..
Closes #67