Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev-dependency-removing UX #24

Open
gnunicorn opened this issue Oct 27, 2020 · 0 comments · May be fixed by #30
Open

Improve dev-dependency-removing UX #24

gnunicorn opened this issue Oct 27, 2020 · 0 comments · May be fixed by #30
Labels
bug Something isn't working

Comments

@gnunicorn
Copy link
Contributor

To prevent dependency-cycles multiple commands currently by default remove dev-dependencies from the Cargo.toml-files first. While neat, the UX is still lacking because:

  • if you change specific files an then run the command, you can't just commit what you had before, because the files were edited
  • if the command fails, you have to revert all chagnes and do your local changes again, as it is pretty hard to figure out what had changed

Let's do the following:

  1. create a .Cargo.toml.backup when we remove the dev-deps
  2. only create that file when we actually removed dev-deps
  3. add another command to quickly revert-de-dev-dep copying back the backup files. allowing to jump back to the state before
  4. maybe automatically run that revert if the patching-command failed?
@gnunicorn gnunicorn added the bug Something isn't working label Oct 28, 2020
@gnunicorn gnunicorn linked a pull request Nov 16, 2020 that will close this issue
5 tasks
@gnunicorn gnunicorn added this to the one point ohhhh milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant