Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BlockBody type with alloy's BlockBody type #12519

Open
mattsse opened this issue Nov 13, 2024 · 1 comment
Open

Replace BlockBody type with alloy's BlockBody type #12519

mattsse opened this issue Nov 13, 2024 · 1 comment
Assignees
@stevencartavia
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 13, 2024

Describe the feature

reth/crates/primitives/src/block.rs

Line 564 in d8fcdf1

pub struct BlockBody {

is almost identical to alloy's blockbody type, but we're likely missing a few things

TODO

  • replace this type with alloy's
  • surface blockers, and add them to alloy (e.g. missing functions)

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 13, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Nov 13, 2024
@stevencartavia
Copy link
Contributor

🙋🏽‍♂️

This was referenced Nov 14, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevencartavia stevencartavia

Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @stevencartavia