Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make engine-tree independent of blockchain-tree crate #12513

Open
mattsse opened this issue Nov 13, 2024 · 1 comment · May be fixed by #12564
Open

Make engine-tree independent of blockchain-tree crate #12513

mattsse opened this issue Nov 13, 2024 · 1 comment · May be fixed by #12564
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 13, 2024

Describe the feature

similar to #12512 but as prep for deprecating the blockchain-tree crate

we already have a separate crate that contains types and traits: blockchain-tree-api

so we need to move all of these:

use reth_blockchain_tree::{
error::{InsertBlockErrorKindTwo, InsertBlockErrorTwo, InsertBlockFatalError},
BlockBuffer, BlockStatus2, InsertPayloadOk2,
};

to

name = "reth-blockchain-tree-api"

TODO

  • move types
  • update imports

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Nov 13, 2024
@Abhishekkochar
Copy link
Contributor

🙋🏽‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants