Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spawn validation requests as blocking #12504

Open
mattsse opened this issue Nov 13, 2024 · 1 comment · May be fixed by #12543
Open

Spawn validation requests as blocking #12504

mattsse opened this issue Nov 13, 2024 · 1 comment · May be fixed by #12543
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 13, 2024

Describe the feature

async fn validate_builder_submission_v3(

and

async fn validate_builder_submission_v4(

are blocking and should be spawned as such, for example:

self.spawn_blocking_io(move |this| {
let state = this.state_at_block_id(at)?;
this.estimate_gas_with(cfg, block_env, request, state, state_override)
})
.await

this means that the API type needs a spawner Box<dyn TaskSpawner>

/// The type that can spawn tasks which would otherwise block.
task_spawner: Box<dyn TaskSpawner>,

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 13, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Nov 13, 2024
@ftupas
Copy link
Contributor

ftupas commented Nov 13, 2024

Hi may I take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants