-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flow] Polymorphic classes #966
Comments
amadeus
added a commit
that referenced
this issue
Jun 26, 2017
Fixes #901 Fixes #966 Fixes #983 Fixes #891 Fixes #885 Fixes #845 Fixes #792 Fixes #723 Fixes #567 This is all a bit hairy, but I think I put a big dent in a lot of the common flow problems that have been reported. I want to sit on these changes for a few days though to make sure I didn't cause a serious regression.
Merged
I've recently created a branch with some flow fixes, if you could do me a solid and test it: #991 |
amadeus
added a commit
that referenced
this issue
Jun 26, 2017
Fixes #901 Fixes #966 Fixes #983 Fixes #891 Fixes #885 Fixes #845 Fixes #792 Fixes #723 Fixes #567 This is all a bit hairy, but I think I put a big dent in a lot of the common flow problems that have been reported. I want to sit on these changes for a few days though to make sure I didn't cause a serious regression.
amadeus
added a commit
that referenced
this issue
Jul 9, 2017
Fixes #901 Fixes #966 Fixes #983 Fixes #891 Fixes #885 Fixes #845 Fixes #792 Fixes #723 Fixes #567 This is all a bit hairy, but I think I put a big dent in a lot of the common flow problems that have been reported. I want to sit on these changes for a few days though to make sure I didn't cause a serious regression.
amadeus
added a commit
that referenced
this issue
Jul 12, 2017
Fixes #901 Fixes #966 Fixes #983 Fixes #891 Fixes #885 Fixes #845 Fixes #792 Fixes #723 Fixes #567 This is all a bit hairy, but I think I put a big dent in a lot of the common flow problems that have been reported. I want to sit on these changes for a few days though to make sure I didn't cause a serious regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I also posted this issue on the vim-flow repo, but since then I saw #592 here which presents the possibility that it needs to be fixed for this plugin.
Using generics/polymorphism with es6 classes seems to break syntax highlighting. Here's the contents of the file causing the issue:
How it appears in my editor is inconsistent. The screenshot that I left on the vim-flow repo is what it looked like yesterday. Today it appears as below. Besides the obvious red highlighted bracket, the
render
method also normally appears in blue.The text was updated successfully, but these errors were encountered: