Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makedir dependency to resolve known security issue #19

Open
amclin opened this issue Apr 13, 2021 · 2 comments · May be fixed by #20
Open

Update makedir dependency to resolve known security issue #19

amclin opened this issue Apr 13, 2021 · 2 comments · May be fixed by #20

Comments

@amclin
Copy link

amclin commented Apr 13, 2021

Security vulnerability in mkdir dependency

Summary

TL;DR: jest-coverage-badges depends on an outdated version of mkdir with security vulnerabilities
Age: LEGACY

Estimated cost: SIMPLE

Description 📋

run npm audit

                       === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.2.1 <1.0.0 || >=1.2.3                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ jest-coverage-badges [dev]                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ jest-coverage-badges > mkdirp > minimist                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1179                            │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 1 low severity vulnerability in 3 scanned packages

Impact 💣

Any projects using jest-coverage-badges are getting security warnings (and with NPM 7, non-zero exit codes) on npm install

Critical in: 2 MONTHS

Proposed solutions :squirrel:

Update mkdirp dependency to latest which no longer depends on the problematic minimist library

(if don't you have any solution in mind, write it)
This Tech debts still don't have any proposed issue.

(if you have solutions in mind, describe it below)
Solution 1.

  • How

  • Pros 💚

  • Cons 💔

Observations 🤔

Files related

files related

Other evidences

Depends on issue X

@flisboac
Copy link

Any updates on this issue?

@christophe77
Copy link

You can use this package : https://www.npmjs.com/package/jest-coverage-badges-ts

azlam-abdulsalam added a commit to azlam-abdulsalam/forcemula that referenced this issue May 28, 2022
This will probably help in removing npm audit alerts caused by jest-coverage-badges, until pamepeixinho/jest-coverage-badges#19 this is resolved. It is better to remove the dependency on this lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants