Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add real tests, add coverage information #2

Open
bittner opened this issue Apr 4, 2016 · 0 comments
Open

Add real tests, add coverage information #2

bittner opened this issue Apr 4, 2016 · 0 comments

Comments

@bittner
Copy link
Member

bittner commented Apr 4, 2016

Missing Tests

As of version 0.1.0 the "tests" executed by tox:

  • don't fail when one or more of the sections of the test YAML file are not recognized
  • don't test whether a missing codeship.yml file results in the expected error message
  • don't test whether an invalid YAML file is handled gracefully (in fact, yaml.parser.ParserError is not being caught yet)
  • don't test whether both single-line sections (e.g. section_name: command_name) and multi-line sections execute correctly
  • don't ensure that empty sections are handled gracefully (TypeError: 'NoneType' object is not iterable)
  • don't test whether the system command calls actually execute certain shell commands
  • don't test whether a failing command aborts the execution chain immediately, yielding a non-zero exit code

Expected Implementation

  1. Those tests should be implemented (in py.test) and be run with coverage.
  2. The coverage information (coveralls) should show as a badge on top of the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant