Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBM generator [broken] #42

Open
severak opened this issue Sep 14, 2021 · 2 comments
Open

EBM generator [broken] #42

severak opened this issue Sep 14, 2021 · 2 comments

Comments

@severak
Copy link

severak commented Sep 14, 2021

I modified your atonal MIDI generator to generate some EBM riffs. It somewhat works, but I ran into some some issues:

  • for some unknown reason it does not send note off when stopped
  • I am not able to figure out how to change parameter from interval to number of steps (per bar)

See ebmgen.lua

@interstar
Copy link

I don't know, but one thought on your first problem.

The "changed" function in the "Is playing" param is trying to turn the note off by calling noteOff which updates newEvents.

But is all this in scope from within the param code?

I presume it stops, because is_playing is successfully changed within that handler. But is_playing is declared as local within the plugin. OTOH, newEvents is just created inside plugin.processBlock ... I wonder what its scope is and if it's visible within the "Is playing" parameter's "changed" method (which might be running in a different thread)

@severak
Copy link
Author

severak commented Sep 16, 2021

@interstar good points! I updated code using your findings and now it actually works. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants