Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native File System and File Watcher #38

Open
timjroberts opened this issue May 19, 2023 · 1 comment
Open

Native File System and File Watcher #38

timjroberts opened this issue May 19, 2023 · 1 comment

Comments

@timjroberts
Copy link
Collaborator

The core LSP types define an EnumerableFileSystem trait. We have an implementation of this trait that sends requests to the LSP client to enumerate the files of workspaces (i.e., as part of indexing), and to retrieve file contents. This implementation uses new LSP request types (extensions), and these are supported directly in Visual Studio Code through our own LSP client implementation.

To support LSP environments outside of Visual Studio Code, we will need another implementation of the EnumerableFileSystem trait that enumerates and reads the file system directly. This implementation should also be extended to optionally watch for file changes, and report them as appropriate LSP notifications.

@timjroberts timjroberts added this to the Serrano [1.0.0] milestone May 19, 2023
@AndrewF001
Copy link
Contributor

Native filesystem for non-wasm build of P4Analyzer has been merged. Unit tests are passing & system is working on Unix, but it's not working on Windows.

Native file watcher wasn't implemented, but a draft was started. That was later removed from the merge and can be seen in this commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants