Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar navigation, discussions, or notifications take over half the width of the page when Indigo theme is used #83

Closed
GlugovGrGlib opened this issue Jun 7, 2024 · 3 comments

Comments

@GlugovGrGlib
Copy link

GlugovGrGlib commented Jun 7, 2024

Description

This issue was reported as part of Redwood release testing. Because the indigo theme is enabled by default since Quince release for all Tutor deployments, this issue is considered a major problem for Open edX.

The original issue found during release testing - openedx/frontend-app-learning#1401

Please find more info about a possible technical solution in the comment: openedx/frontend-app-learning#1401 (comment)

Steps to Reproduce

  1. Login to an instance using the Indigo theme as an admin user to ensure the courseware.enable_navigation_sidebar waffle flag is enabled
  2. Navigate to an in-course experience page
  3. With the sidebar navigation expanded, view the page

Expected Behavior

  1. The sidebar navigation when expanded takes up much less than half of the page horizontally (see attached image from an in-course experience page using the Open edX theme)
  2. There is a reasonable amount of blank space on either side of the course content/sidebar content

Default Open edX theme:

image

Actual Behavior

  1. The sidebar navigation when expanded takes up half of the page horizontally (see attached image from an in-course experience page using the Indigo theme)
  2. There is a lot of extra blank space on either side of the course content/sidebar content

Full HD:

image

Wide screen:

image
@GlugovGrGlib
Copy link
Author

@DawoudSheraz FYI about this product request

@DawoudSheraz
Copy link
Contributor

Thanks @GlugovGrGlib
FYI @hinakhadim

@hinakhadim
Copy link
Collaborator

Hi @GlugovGrGlib ,
Thanks for taking time and identifying this. This PR will resolve this issue with tutor-indigo version 17.4.0.

@github-project-automation github-project-automation bot moved this from Pending Triage to Done in Tutor project management Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants