Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks on i386 (and potentially other 32-bit systems): error: cannot define or redeclare 'process_buffer_impl' here because namespace 'impl' does not enclose namespace 'fir_filter' #1608

Open
yurivict opened this issue Dec 5, 2024 · 2 comments
Assignees

Comments

@yurivict
Copy link

yurivict commented Dec 5, 2024

In file included from /wrkdirs/usr/ports/multimedia/ossia-score/work/.build/3rdparty/libossia/kfr_build/src/dsp/CMakeFiles/kfr_dsp_neon.dir/Unity/unity_0_cxx.cxx:7:
/wrkdirs/usr/ports/multimedia/ossia-score/work/ossia-score-3.3.2/3rdparty/libossia/3rdparty/kfr/src/dsp/fir.cpp:51:24: error: cannot define or redeclare 'process_buffer_impl' here because namespace 'impl' does not enclose namespace 'fir_filter'
   51 | void fir_filter<T, U>::process_buffer_impl(U* dest, const U* src, size_t size)
      |      ~~~~~~~~~~~~~~~~~~^
/wrkdirs/usr/ports/multimedia/ossia-score/work/ossia-score-3.3.2/3rdparty/libossia/3rdparty/kfr/src/dsp/fir.cpp:53:74: error: invalid use of 'this' outside of a non-static member function
   53 |     make_univector(dest, size) = fir(make_univector(src, size), std::ref(this->state));
      |                                                                          ^
/wrkdirs/usr/ports/multimedia/ossia-score/work/ossia-score-3.3.2/3rdparty/libossia/3rdparty/kfr/src/dsp/fir.cpp:53:53: error: use of undeclared identifier 'src'
   53 |     make_univector(dest, size) = fir(make_univector(src, size), std::ref(this->state));
      |                                                     ^
/wrkdirs/usr/ports/multimedia/ossia-score/work/ossia-score-3.3.2/3rdparty/libossia/3rdparty/kfr/src/dsp/fir.cpp:53:58: error: use of undeclared identifier 'size'
   53 |     make_univector(dest, size) = fir(make_univector(src, size), std::ref(this->state));
      |                                                          ^
/wrkdirs/usr/ports/multimedia/ossia-score/work/ossia-score-3.3.2/3rdparty/libossia/3rdparty/kfr/src/dsp/fir.cpp:53:20: error: use of undeclared identifier 'dest'
   53 |     make_univector(dest, size) = fir(make_univector(src, size), std::ref(this->state));
      |                    ^
/wrkdirs/usr/ports/multimedia/ossia-score/work/ossia-score-3.3.2/3rdparty/libossia/3rdparty/kfr/src/dsp/fir.cpp:53:26: error: use of undeclared identifier 'size'
   53 |     make_univector(dest, size) = fir(make_univector(src, size), std::ref(this->state));
      |                          ^

log

Version: 3.3.2
FreeBSD 14.1

@jcelerier
Copy link
Member

hm, this looks like a build failure in https://github.com/kfrlib/kfr

@jcelerier
Copy link
Member

It works on 32-bit in general as for instance the WASM port is from the point of view of the code akin to 32-bit x86.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants