Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Housename display after search #628

Open
Zirochkabila opened this issue Dec 25, 2024 · 3 comments
Open

Change Housename display after search #628

Zirochkabila opened this issue Dec 25, 2024 · 3 comments
Assignees
@alisa911
Labels
website
Milestone
5.0-web

Comments

@Zirochkabila
Copy link
Collaborator

Zirochkabila commented Dec 25, 2024 •
edited
Loading

Description

Probably related 597
It seems that the search within Ukraine does not work

Nothing is displayed in the search for саксаганського 69

OsmAnd
OsmAnd test
OSM

<html>
<head><title>404 Not Found</title></head>
<body>
<center><h1>404 Not Found</h1></center>
<hr><center>nginx/1.18.0 (Ubuntu)</center>
</body>
</html>
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->
<!-- a padding to disable MSIE and Chrome friendly error page -->

 try {
        const fullOptions = Object.assign({}, { redirect: 'manual' }, options);
        response = await fetch(fullURL, fullOptions);
    } catch (e) {
        // got general error (have no response)
        console.debug('fetch-catch-error', url, e);
        const ret = { ok: false, text: () => null, json: () => null, blob: () => null, data: null };
        if (options?.throwErrors) {
            const error = new Error('fetch-catch-error');
            error.response = ret;
            throw error;
        } else {
            return ret;
        }
    }

Steps to reproduce

  1. Click on one of the links above > Type саксаганського 69 in the search bar > Press Enter

Actual result

OsmAnd & OsmAnd test Screenshot 2023-01-31 at 11 19 41 Screenshot 2023-01-31 at 11 19 41

Expected result

OSM or App Screenshot 2023-01-31 at 11 19 41
2024-12-25.11.11.06.mp4
@Zirochkabila Zirochkabila changed the title Search doesn't work саксаганського 69 Can't find place in the search (looks like search doesn't work) саксаганського 69 Dec 25, 2024
@yuriiurshuliak
Copy link

I couldn’t reproduce the issue. Please try the following:

  1. Open the web version: https://test.osmand.net/map/search/#19/50.43672/30.50515.
  2. Search for "саксаганського 69."

Result:
The address is successfully found both on the web version and in the app. This appears to be a local issue.

photo_2024-12-27_12-17-56

@yuriiurshuliak
Copy link

Also I wanted to share some observations:

  • On macOS, the behavior of the search engine appears to be influenced by the geolocation settings:

    • When geolocation is activated, searching for "саксаганського 69." yields no results.
    • When geolocation is disabled, the search works as expected and successfully finds "саксаганського 69."
    • To reproduce, you can open the web version of OsmAnd on macOS, locate the geolocation icon in the top line of the site, and select "Always allow access to geolocation." After refreshing the page (Shift + Command + R), try searching again for "саксаганського 69." You should notice that no results are displayed.

  • On Windows, the search works correctly regardless of the geolocation setting, always providing accurate results.

screen-recording-2024-12-27-at-121003_qHS584ng.mp4

@vshcherb
Copy link
Member

We need to fix display, "69" is incomplete output. Check android it has full address street name and city name.

So to fix display name as in Android

@vshcherb vshcherb added this to the 5.0-web milestone Dec 28, 2024
@vshcherb vshcherb changed the title Can't find place in the search (looks like search doesn't work) саксаганського 69 Change Housename display after search Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alisa911 alisa911

Labels
website
Projects
None yet
Milestone
5.0-web
Development

No branches or pull requests
4 participants
@vshcherb @alisa911 @Zirochkabila @yuriiurshuliak