Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive on "light:colour" values in descriptive color temperature format #2312

Open
Lumikeiju opened this issue Aug 15, 2024 · 2 comments

Comments

@Lumikeiju
Copy link

The validator should not flag light:colour values entered as a descriptive colour temperature name (in the format "light:colour"~"amber|daylight|warmwhite|softwhite|neutralwhite|brightwhite|coolwhite|coldwhite"); note that, in fairness, these values are nearly exclusively documented and used by me so far (though currently with >350 uses combined).

Item: 3091
Class: 30914
Subtitle: Unknown or invalid colour in tag 'light:colour'
Example: https://osmose.openstreetmap.fr/en/issue/8640d1d3-a360-9673-5459-6524728cd43e

@Famlam
Copy link
Collaborator

Famlam commented Aug 15, 2024

I must say I'm not really sure if we should support such tags, being highly subjective.

@Lumikeiju
Copy link
Author

They're not any more subjective than the standard descriptive colour names which are widely used and supported. These specific values don't have widely-known standard colour equivalents and these values are widely used in the lighting industry - almost all LED bulbs' packaging includes one of these descriptive color temperature names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants