Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime isn't necessarily in UTC (depend on timezone settings) #13

Open
deamn opened this issue Aug 27, 2020 · 3 comments
Open

Datetime isn't necessarily in UTC (depend on timezone settings) #13

deamn opened this issue Aug 27, 2020 · 3 comments

Comments

@deamn
Copy link

deamn commented Aug 27, 2020

Please see https://issues.apache.org/jira/browse/NIFI-5091

Could you update your fork with that pull request?
shyiko#292

@osheroff
Copy link
Owner

hi,
feel free to open a pull request here,
but your PR isn't necessarily more correct than the existing code,
and I feel like it would break quite a lot of code.

The existing code asserts that the server is always running in UTC, and ignores what timezone the client is in.
Your code asserts that the server is always running in the timezone that the client is in.

Neither is correct; as far as I'm concerned the only correct thing to do here is to query the server and see what timezone it's in, and use that to convert the integers into dates.

@TymGitHub
Copy link

that's right

@TymGitHub
Copy link

TymGitHub commented Sep 9, 2020

代码中写死GMT,感觉不太好

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants