many: enable support for librepo based rpm downloading #1132
+335
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the two new `Path` and `RepoID` fields to the rpmmd.PackageSpec so that librepo can use them as it needs to correlate a package to a repo to generate the right mirror id.
This commit adds a wrapper for the org.osbuild.librepo source to download RPMs.
This commit enables librepo sources generation. Currently guarded behind a hacky OSBUILD_USE_LIBREPO environment.
This commit changes the signature of `SerializeFull()` to take a new `Inputs` struct and a new `Options` struct. The `inputs` make it easier to extend the function as for new inputs the signature no longer needs to change. And `options` allows us to pass extra paramters like what rpm downloader to use. Note that this keeps a compatibility Serialize() for now, mostly to avoid churn in this PR but we definitely want to clean this up and fix the callers.
This commit enables to select what rpm downloader backend to use. The signature of GenSources() is just expanded to take an additonal parameter. It would be nice to re-use the `manifest.Inputs` struct but it is (subtly) different from what GenSource needs :/ I was also tempated to add a "Options" struct to GenSources instead of the enum but YAGNI - if we ever need to add another one this will become a options struct.
thozza
force-pushed
the
librepo-sources-osbuild1974
branch
from
dae4acd to
63df312
Compare
|
Rebased due to image build cache layout change (#1130) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft as it is light on tests and also needs osbuild pr#1974 first]
This PR adds support for (optional) librepo based rpm downloading. It can be controlled when generating the manifest via the new
RpmDownloaderiota. This needs osbuild PR#1974.Note that this PR implements manifest.Manifest.SerializeFull() which I think we do not want in the final PR, I did that just to keep the size of the PR low so that validating the approach is easier.