Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think through plotfreqresp() #24

Open
4 tasks
mchitre opened this issue Jul 20, 2021 · 0 comments
Open
4 tasks

Think through plotfreqresp() #24

mchitre opened this issue Jul 20, 2021 · 0 comments
Assignees

Comments

@mchitre
Copy link
Member

mchitre commented Jul 20, 2021

  • freqresp() has been renamed to plotfreqresp() as DSP.jl just introduced a freqresp function that conflicts. Should we keep this name or is there a better alternative?
  • We should default to about 30 dB dynamic range for the magnitude plot.
  • We currently pass options to both phase and magnitude subplots. While this makes sense for some options (e.g. colors, line types, x-limits), it doesn't make sense for others (e.g. y-limits). How should we fix this?
  • Should we allow just phase or just magnitude plot?
@mchitre mchitre added the enhancement New feature or request label Jul 20, 2021
@mchitre mchitre self-assigned this Jul 20, 2021
@mchitre mchitre removed the enhancement New feature or request label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant