Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORAMA0001 when calling insertMultiple #837

Open
simonljus opened this issue Nov 7, 2024 · 2 comments
Open

ORAMA0001 when calling insertMultiple #837

simonljus opened this issue Nov 7, 2024 · 2 comments

Comments

@simonljus
Copy link

Describe the bug

When using the function insertMultiple (sync) with > 1000 documents, a ORAMA0001 warning is shown.

[ORAMA0001] Warning ... please use insertMultiple

Stack trace: insertMultiple -> insertInnerMultipleSync -> processAllBatches -> processNextBatch -> insert -> insertInnerSync -> trackInsert

To get rid of the warning locally: Calling insertMultiple multiple times in batches of < 1000 documents)

To Reproduce

Call insertMultiple with > 1000 documents (setting batch size to <= 1000 does not matter).

Expected behavior

When using insertMultiple, this warning should not appear.

Environment Info

Node: 22.11.0
Orama: 3.0.1

Affected areas

Data Insertion

Additional context

No response

@micheleriva
Copy link
Member

Uhm... that looks like a bug. Thanks for noticing

@isaachinman
Copy link

isaachinman commented Jan 13, 2025

Have also just come across this. Even lowering the optional batch size arg does not mitigate the warning.

Does this mean that insertMultiple is just calling insert in a loop, and is no better in terms of performance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants