Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to remove googles internal libarys #4

Open
AdaBehan opened this issue Feb 17, 2023 · 0 comments
Open

Refactor tests to remove googles internal libarys #4

AdaBehan opened this issue Feb 17, 2023 · 0 comments

Comments

@AdaBehan
Copy link

Currently the tests for the project requires the use of googles internal library's. Without access to these library's a developer cannot run the tests against the codebase. I prepose we change these dependency's to equivalent open source ones.

https://github.com/opiproject/smbios-validation-tool/blob/main/smbios_validation_tool/validator_test.py#L22
https://github.com/opiproject/smbios-validation-tool/blob/main/smbios_validation_tool/error_bucket_test.py#L4
https://github.com/opiproject/smbios-validation-tool/blob/main/smbios_validation_tool/rules_test.py#L23
https://github.com/opiproject/smbios-validation-tool/blob/main/smbios_validation_tool/matcher_test.py#L23

The three packages are.

from google3.pyglib import resources
from google3.testing.pybase import googletest
from google3.testing.pybase import parameterized
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant