We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open any config object like a Device, Template or VPN Server.
Make sure there's some config defined.
Try opening the preview with the ALT+P keys.
Expected autcome: preview overlay opens. Actual outcome: nothing happens.
Try opening the preview by clicking on the preview button. Now press ESC key to close.
Expected autcome: preview overlay closes. Actual outcome: nothing happens.
We need to continue making OpenWISP more robust and prevent these UI bugs from happening again. Fortunately, we have already added some Selenium UI tests here: https://github.com/openwisp/openwisp-controller/blob/master/openwisp_controller/config/tests/test_selenium.py
We must write 2 new tests which replicate these issues: we must ensure the tests fail with an understandable error message before applying the fix.
The text was updated successfully, but these errors were encountered:
Seems to be an interaction with openwisp/openwisp-notifications#275, nonetheless, I still think it's good to add these selenium tests.
Sorry, something went wrong.
No branches or pull requests
Open any config object like a Device, Template or VPN Server.
Make sure there's some config defined.
Problem 1: Opening Preview
Try opening the preview with the ALT+P keys.
Expected autcome: preview overlay opens.
Actual outcome: nothing happens.
Problem 1: Closing Preview
Try opening the preview by clicking on the preview button.
Now press ESC key to close.
Expected autcome: preview overlay closes.
Actual outcome: nothing happens.
Automated tests
We need to continue making OpenWISP more robust and prevent these UI bugs from happening again.
Fortunately, we have already added some Selenium UI tests here:
https://github.com/openwisp/openwisp-controller/blob/master/openwisp_controller/config/tests/test_selenium.py
We must write 2 new tests which replicate these issues: we must ensure the tests fail with an understandable error message before applying the fix.
The text was updated successfully, but these errors were encountered: