Relax rejection of GTFS flex trips that also contain continuous stopping #6231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
Bug
TriMet
GTFS
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6231 +/- ##
=============================================
- Coverage 69.75% 69.75% -0.01%
Complexity 17652 17652
=============================================
Files 2007 2007
Lines 75563 75561 -2
Branches 7731 7730 -1
=============================================
- Hits 52711 52707 -4
- Misses 20141 20146 +5
+ Partials 2711 2708 -3 ☔ View full report in Codecov by Sentry. |
|
@m-mcqueen @fpurcell If you want to you can try out this version and deploy it to your servers before review has concluded. |
leonardehrenfried
added
the
bump serialization id
leonardehrenfried
force-pushed
the
flex-continuous
branch
from
c3370c1
to
ac64f85
Compare
leonardehrenfried
force-pushed
the
flex-continuous
branch
from
ac64f85
to
8f6ba7b
Compare
habrahamsson-skanetrafiken
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This brings OTP in line with the GTFS spec by allowing flex and continuous stopping in the same trip as long as it's not mixed in the very same stop time.
There is also a small improvement to the debug UI where routes without a publicCode/shortName use the long name as the fallback.
Issue
Closes #6230
Unit tests
The majority of the code is test refactoring. Lots of tests for this behavior added.
Documentation
n/a
Bumping the serialization version id
I'm changing static method on a file that is being serialised so I'm bumping just in case.