Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle websockets version 14, verbose error output #236

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Nov 12, 2024

With websockets>13, people were experiencing failures caused by a read_limit kwarg, which doesn't exist in websockets 14+

/Users/<me>/btcli_venv/lib/python3.12/site-packages/websockets/asyncio/client.py", line 367, in create_connection
    _, connection = await loop.create_connection(factory, **kwargs)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: BaseEventLoop.create_connection() got an unexpected keyword argument 'read_limit'

This keeps the websockets req as websockets>=12.0, but adds a check for the version to see whether the read_limit is applicable.

Also adds verbose console for the tracebacks of any error handled within the CLI using the --verbose flag.

@thewhaleking thewhaleking requested a review from a team November 12, 2024 08:41
@thewhaleking thewhaleking linked an issue Nov 12, 2024 that may be closed by this pull request
@thewhaleking thewhaleking changed the title websockets version bump Handle websockets version 14 Nov 12, 2024
@thewhaleking thewhaleking changed the title Handle websockets version 14 Handle websockets version 14, verbose error output Nov 12, 2024
@thewhaleking thewhaleking merged commit e06a0cc into staging Nov 12, 2024
1 check passed
@thewhaleking thewhaleking deleted the fix/thewhaleking/websockets-bump branch November 12, 2024 20:19
@thewhaleking thewhaleking mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New installs not working
2 participants