Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow friendly names in disk description #48

Open
benemon opened this issue Sep 11, 2020 · 7 comments
Open

Allow friendly names in disk description #48

benemon opened this issue Sep 11, 2020 · 7 comments
Assignees
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@benemon
Copy link

benemon commented Sep 11, 2020

As an OpenShift on oVirt/RHV Admin
I want to put a friendly name in the disk description in oVirt/RHV
So I can identify which disks in oVirt/RHV map to which OpenShift clusters when I have multiple OpenShift clusters deployed.

@benemon
Copy link
Author

benemon commented Sep 11, 2020

My initial thought on this would be an extra parameter in the StorageClass which allowed for a custom identifier to be mapped to the 'Description' field on the ovirt/RHV disk.

@bennyz
Copy link
Member

bennyz commented Oct 22, 2020

Do you mean a key like "cluster1" that will be pre/appended to the description like: "cluster1-pvc-"?
(sorry for the late reply by the way, I forgot to set notifications for this repo)

@benemon
Copy link
Author

benemon commented Oct 22, 2020

Not a problem @bennyz

A pre/appended key would also work - basically anything that would identify to an admin / user exactly which PVs belong to which cluster. I suggested Description as it is currently undefined for the disks, so it might have been simpler to implement.

@bennyz
Copy link
Member

bennyz commented Oct 22, 2020

Ah, sorry, I confused alias with description. Anyway, this sounds like a good idea and I see no reason not support this, I'll add a ticket to track this

Thanks!

@benemon
Copy link
Author

benemon commented Oct 22, 2020

Awesome, thanks!

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2021
@bennyz
Copy link
Member

bennyz commented Feb 15, 2021

/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants