Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the ML libraries should use body keyword arg instead of payload for the JSON document to mirror the other OpenSearch APIs #397

Open
rbpasker opened this issue Jun 28, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rbpasker
Copy link

the ML python libraries use payload as they keyword argument for the of the HTTP request. This diverges from the main OpenSearech APIs, which the keyword body, eg, Ingest:

image

for example:

def create_standalone_connector(self, payoad: dict):

should be:

def create_standalone_connector(self, body: dict):

to conform

def create_standalone_connector(self, payload: dict):

@rbpasker rbpasker added bug Something isn't working untriaged labels Jun 28, 2024
@dblock
Copy link
Member

dblock commented Jul 22, 2024

Makes sense, thanks for opening this @rbpasker. Care to try and fix it?

[Catch All Triage w/ 1, 2, 3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants