Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Bumping pandas version from 1.5.0 to 2.x #270

Open
thanawan-atc opened this issue Aug 31, 2023 · 17 comments
Open

[Enhancement] Bumping pandas version from 1.5.0 to 2.x #270

thanawan-atc opened this issue Aug 31, 2023 · 17 comments
Assignees
Labels
CCI enhancement New feature or request good first issue Good for newcomers

Comments

@thanawan-atc
Copy link
Contributor

thanawan-atc commented Aug 31, 2023

To bump pandas version from 1.5.0 to 2.x, we have to make changes to resolve issues such as

To see the full error on GitHub Actions,

  1. Change pandas version for integration test to ~2.0.1 (here and here) as below
    export PANDAS_VERSION=${PANDAS_VERSION-2.0.1}
    @nox.parametrize("pandas_version", ["2.0.1"])
    Note that we can bump it to be 2.0.3 or above as well.
  2. Integration test should be run automatically when you push any changes to the branch. You can see the log by going to Actions tab > Click Integration tests on the right menu > Choose the test that is running on the branch with your changes

See example of GitHub Actions log here: https://github.com/thanawan-atc/opensearch-py-ml/actions/runs/6040143974/job/16390355081

We have to change those deprecated functions so that it works with pandas 2.x.

Once there is no error in integration test, we can then update requirements.txt , requirements-dev.txt , requirements-docs.txt , ci file, and noxfile to use new pandas version.

Lastly, make sure that the integration workflow and build-deploy-doc workflow do not fail with the new pandas version.

@thanawan-atc thanawan-atc added enhancement New feature or request untriaged labels Aug 31, 2023
@thanawan-atc thanawan-atc changed the title [FEATURE] Bumping pandas version from 1.5.0 to 2.x [Enhancement] Bumping pandas version from 1.5.0 to 2.x Aug 31, 2023
@dtaivpp
Copy link
Contributor

dtaivpp commented Sep 1, 2023

@thanawan-atc should we not go to 2.0.3 since it's the latest in that line?

@dtaivpp
Copy link
Contributor

dtaivpp commented Sep 1, 2023

Also, do you think we should change the requirements.txt to be <2.0 as 2.1 is currently broken and is not getting added to testing?

@dhrubo-os dhrubo-os added CCI and removed untriaged labels Sep 6, 2023
@thanawan-atc
Copy link
Contributor Author

I believe 2.0.3 also made the integration test failed as well. Our plan is to update pandas-related functions that were deprecated and then bump pandas from 1.5.0 to 2.x.

@dhrubo-os
Copy link
Collaborator

dhrubo-os commented Sep 6, 2023

@Yerzhaisang you can pick up this task. Please let me know if you have any question regarding this.

@Yerzhaisang
Copy link
Contributor

got it

@dhrubo-os dhrubo-os added the good first issue Good for newcomers label Sep 27, 2023
@wuzhijing0127
Copy link

Can I work on this issue?

@Yerzhaisang
Copy link
Contributor

Can I work on this issue?

If I can't resolve this issue on this weekend, you can take it

@Sylviama1026
Copy link

May I try on this issue?

@dhrubo-os
Copy link
Collaborator

Sure, assigning it to you.

@miguelsousa
Copy link

The upgrade to 2.x should also resolve #263

@Yerzhaisang
Copy link
Contributor

Yerzhaisang commented Dec 4, 2023

Dear @dhrubo-os , can you please update this issue card?

@Yerzhaisang
Copy link
Contributor

If this issue is still actual and there is no updates, reassign it to me please

@soapergem
Copy link

Hey @Yerzhaisang any updates? I see you created a PR last month and I can confirm it works (I ran pip install git+https://github.com/Yerzhaisang/opensearch-py-ml.git@dev) so what needs to happen in order to get this merged in?

@Yerzhaisang
Copy link
Contributor

@soapergem Thank you for the comment.

Dear @dhrubo-os, can I start fix from scratch and raise another PR. If yes, I will close #366 and raise another PR. Thank you!

@dhrubo-os
Copy link
Collaborator

Sure, go ahead.

@dhrubo-os
Copy link
Collaborator

@Yerzhaisang are you still working on this issue?

@Yerzhaisang
Copy link
Contributor

Yerzhaisang commented Oct 10, 2024

@Yerzhaisang are you still working on this issue?

Dear @dhrubo-os ,
please, just follow the commits on this branch

Already did:
Replaced mad method with custom one.
Started replacing _construct_axes_from_arguments method with custom one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCI enhancement New feature or request good first issue Good for newcomers
Projects
None yet
8 participants