Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sed commands in META.md do not work on mac #137

Open
abhinavGupta16 opened this issue Apr 5, 2022 · 3 comments
Open

[BUG] Sed commands in META.md do not work on mac #137

abhinavGupta16 opened this issue Apr 5, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@abhinavGupta16
Copy link

What is the bug?
The find and replace text commands using sed in https://github.com/opensearch-project/opensearch-plugins/blob/main/META.md does not work on mac

How can one reproduce the bug?
run the find with sed commands on mac

What is the expected behavior?
The commands should work as expected on linux and mac

What is your host/environment?

  • OS: Mac
@abhinavGupta16 abhinavGupta16 added bug Something isn't working untriaged labels Apr 5, 2022
@dblock
Copy link
Member

dblock commented Apr 5, 2022

I think for OSX you want to switch your sed to use gnu sed, https://stackoverflow.com/questions/30003570/how-to-use-gnu-sed-on-mac-os-10-10-brew-install-default-names-no-longer-su, otherwise it's endless pain of having sed that behaves differently on linux/mac. Maybe confirm and add a note?

@abhinavGupta16
Copy link
Author

I think for OSX you want to switch your sed to use gnu sed, https://stackoverflow.com/questions/30003570/how-to-use-gnu-sed-on-mac-os-10-10-brew-install-default-names-no-longer-su, otherwise it's endless pain of having sed that behaves differently on linux/mac. Maybe confirm and add a note?

I am good with any solution that helps with mac

@dblock dblock removed the untriaged label Apr 11, 2022
@dblock
Copy link
Member

dblock commented Apr 11, 2022

@abhinavGupta16 The fix here is to update the instructions and/or add a note on Mac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants