Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Testing compatibility on different platforms #207

Closed
VachaShah opened this issue Aug 12, 2022 · 3 comments · Fixed by #208
Closed

[FEATURE] Testing compatibility on different platforms #207

VachaShah opened this issue Aug 12, 2022 · 3 comments · Fixed by #208
Labels
enhancement New feature or request untriaged

Comments

@VachaShah
Copy link
Collaborator

Is your feature request related to a problem?

We test our clients for Linux platform but we do not know if these clients work smoothly on platforms like windows/mac etc.
Coming from opensearch-project/opensearch-clients#18

What solution would you like?

Test the client with most popular platforms and CPU architectures:

  • x64
  • ARM
  • Linux
  • Windows
  • MacOS
@VachaShah VachaShah added enhancement New feature or request untriaged labels Aug 12, 2022
This was referenced Aug 12, 2022
Open
Merged
@dblock
Copy link
Member

dblock commented Aug 15, 2022

I think I merged #208 too fast. Looks like this doesn't run unit tests (it probably should) and those are in https://github.com/opensearch-project/opensearch-java/blob/main/.github/workflows/test-unit.yml.

@dblock dblock reopened this Aug 15, 2022
@VachaShah VachaShah mentioned this issue Aug 15, 2022
Merged
@VachaShah
Copy link
Collaborator Author

Raised PR #210 for adding support in unit tests.

@VachaShah
Copy link
Collaborator Author

Done in PRs #208 and #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding test support for multiple platforms VachaShah/opensearch-java
2 participants
@dblock @VachaShah