Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude COTD reruns from table when "Include reruns" is unchecked #83

Closed
chrisdunnbirch opened this issue Feb 9, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@chrisdunnbirch
Copy link

chrisdunnbirch commented Feb 9, 2024

It is consistently confusing that reruns are included in the table of COTD results when the "Include reruns" checkbox is not checked at the top of the page.

I would personally prefer them to be hidden so that what you see in the table matches up with the stats you see in the header of the page.

Just to clarify, the colors don't show your best division, it's just based on the div number.
Div 1 is green, 2 is gold, 3 is silver, 4 is bronze, everything else is dark grey.
Not 100% intuitive though to be fair.

Either way, the most obvious solution to the confusion is probably just to remove all rerun entries from the table if the checkbox is unchecked. Probably will require some thinking about whether the API will need to be adjusted as well (to prevent the "Load more" button from doing nothing if only reruns get loaded and none of them get shown).

Originally posted by @davidbmaier in #66 (comment)

@davidbmaier davidbmaier added the enhancement New feature or request label Feb 9, 2024
@davidbmaier davidbmaier self-assigned this Feb 9, 2024
@davidbmaier
Copy link
Member

Fixed, the table data should now be consistent with the stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants