Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaderboardposition in Campaign Overview #68

Open
Platyyyy opened this issue Sep 28, 2023 · 5 comments
Open

Leaderboardposition in Campaign Overview #68

Platyyyy opened this issue Sep 28, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Platyyyy
Copy link

Platyyyy commented Sep 28, 2023

Hello,

would it be possible to add your Leaderboard Position in the Overview of a Campaign as a little QOL change?
Maybe directly under the Personal Best time?

image

Thanks!

@davidbmaier davidbmaier added the enhancement New feature or request label Sep 28, 2023
@davidbmaier
Copy link
Member

davidbmaier commented Sep 28, 2023

As mentioned on Discord, I think this would require a separate request for each map in a campaign to get the position via the score/surround API - obviously that could be cached but it doesn't really scale well since the cache would be per user (and users would expect it to be up to date when opening the page).

But maybe I'm missing some way to achieve this - @codecat you got an idea by any chance?

@codecat
Copy link
Member

codecat commented Sep 28, 2023

Yeah I agree, I don't really know of any good way to do it. If we did a request for every map & every player, Nadeo will complain at us pretty quickly :P

@Platyyyy
Copy link
Author

I don't know how this works in the background, but the information is already there when you are on the leaderboard of a map.
Isn't it possible to somehow "copy" that over to the overview?

I'm probably thinking too simple
image

@davidbmaier
Copy link
Member

It's available there because it's requested by the page during load - but that's always one map at a time. If we have to request 25 different maps every time someone just looks at a campaign, it increases the server load quite a bit.

@Platyyyy
Copy link
Author

Ooh, ok ok, that makes sense.
Thanks for explaining

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants