Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (non-existing) boolean occursIn fields to response #299

Closed
antonisloizou opened this issue Oct 7, 2015 · 6 comments
Closed

Add (non-existing) boolean occursIn fields to response #299

antonisloizou opened this issue Oct 7, 2015 · 6 comments

Comments

@antonisloizou
Copy link

Described here : openphacts/OPS_LinkedDataApi#17

@madgpap
Copy link

madgpap commented Oct 8, 2015

Thanks!

@madgpap
Copy link

madgpap commented Oct 21, 2015

any progress with this? we need all boolean occursIn fields to be present consistently, otherwise KNIME gets confused....

@antonisloizou
Copy link
Author

Will not be progressed until 2.0 is out

@danidi
Copy link

danidi commented Oct 22, 2015

@madgpap Also other API calls contain results which might be missing according to the query (e.g. drugbank data will only show up in the API if data is there, but if no data is available, you won't get empty fields back). That's one of the reasons I usually don't use the generic "to table" implementations from KNIME, but the Json path one (Xpath should work as well). Once you define a column you want to retrieve there, you will get an empty value if no data is available. Will this solve your issue for now?

@nicklynch nicklynch added this to the 2.1 milestone Oct 22, 2015
@madgpap
Copy link

madgpap commented Oct 22, 2015

Thanks @antonisloizou and @danidi. Indeed, there are workarounds but I'm after a more elegant, intuitive and generic solution, robust during looping. For this particular case, I believe all 6 fields (title, abstract, claims, description, images, CWU) should exist in the response, even when empty. Actually, technically, they are not empty (like the drugbank example); they are False, which is quite different.

antonisloizou pushed a commit to openphacts/OPS_LinkedDataApi that referenced this issue Jan 28, 2016
@antonisloizou
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants