Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The table of contents links are broken #7

Open
jmichel80 opened this issue Jul 12, 2023 · 3 comments
Open

The table of contents links are broken #7

jmichel80 opened this issue Jul 12, 2023 · 3 comments
Assignees

Comments

@jmichel80
Copy link
Collaborator

Clicking on a link in the table of content of the notebooks (one example below)

image

Does not lead to the relevant section of the notebook.

image

The links are also inactive in colab.

@sef43
Copy link
Contributor

sef43 commented Jul 12, 2023

this seems like a recent github change, i copied the method here https://github.com/michellab/BioSimSpaceTutorials/blob/main/04_fep/01_intro_to_alchemy/alchemical_introduction.ipynb

Where they are also now broken

@sef43
Copy link
Contributor

sef43 commented Jul 12, 2023

I have just temporarily removed the TOC links to avoid confusion

@sef43
Copy link
Contributor

sef43 commented Jul 18, 2023

I think relying on GitHub preview rendering of the .ipynb jupyter notebooks might be not be the way to go. We have no control over how it renders, as shown by this issue, and I do not think this part of GitHub is open source code or if it is I have no idea where to post an issue.

Instead we could use https://nbviewer.org/
Or we could convert the notebooks to html ourselves to upload here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants