Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When the last batch of releases is done and in a paused state, the rollback will be considered a new release #144

Open
machine3 opened this issue May 19, 2023 · 2 comments

Comments

@machine3
Copy link

last paused

image

rollback

image

reason:

https://github.com/openkruise/rollouts/blob/v0.3.0/pkg/util/controller_finder.go#L372

RS with zero replices is filtered out here

@zmberg
Copy link
Member

zmberg commented May 30, 2023

@machine3 The probability is that the configuration you rolled back this time has some differences from the original v1 configuration.

@machine3
Copy link
Author

@zmberg It is because the number of old RS replicas has been reduced to 0, but the rollout is not over yet, so it should be possible to roll back at this time.

Mingzhou knows about this problem, I told him about it on DingDing.

machine3 added a commit to machine3/rollouts that referenced this issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants