Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated with tabs, padding to faq, menuIcon and close button #34

Closed
wants to merge 8 commits into from
Closed

updated with tabs, padding to faq, menuIcon and close button #34

wants to merge 8 commits into from

Conversation

SutarPrasad
Copy link
Member

@SutarPrasad SutarPrasad commented Aug 23, 2023 •
edited
Loading

  • Describe the changes implemented in this PR (Bug fix, feature, docs update, ...)
    In this PR I have added the tabs inside the sidebar, padding to faq content MenuIcon and close button for reduced screen size mode and styling to it. These changes cover the review mentioned in 28 add obs explainer page #30

  • Please check if the PR fulfils these requirements

@SutarPrasad SutarPrasad linked an issue Aug 23, 2023 that may be closed by this pull request
Add tabs and styling to the sidebar and padding to FAQ #33
Open
@SutarPrasad SutarPrasad requested a review from gareth-j August 23, 2023 23:20
@SutarPrasad SutarPrasad self-assigned this Aug 23, 2023
@gareth-j
Copy link
Contributor

gareth-j commented Aug 29, 2023 •
edited
Loading

Just a few higher level suggestions for this:

  • the selection and clear button/dropdown should be below the plot
  • I don't think we need the shadowing around the items
  • for me the burger menu has a surrounding line on a narrow window

@SutarPrasad
Copy link
Member Author

I will check the burger menu for the small screen, it did not pop up for me. I will change the configurations and hunt for it to be resolved.
I would stick to the species and clear at the top because it then generates a flow in users' minds going from top to bottom. It usually is left to right from top to bottom.

@SutarPrasad
Copy link
Member Author

@gareth-j I am trying to have a card-based styling to the dashboard, However, to do so it will take some more time hence the shadowing is the closest form of mimicking card-based structure. Dashboards implement a card-based structure to avoid components being as plain as some kind of webpage.

@gareth-j
Copy link
Contributor

gareth-j commented Sep 1, 2023

I don't think we need these changes at the moment. Thanks for looking at this but I think the previous interface was cleaner.

@SutarPrasad
Copy link
Member Author

SutarPrasad commented Sep 1, 2023 via email •
edited
Loading

@SutarPrasad SutarPrasad force-pushed the 33-tabs-to-sidebar-padding-FAQ branch from 17278ea to e643015 Compare September 1, 2023 10:11
@SutarPrasad
Copy link
Member Author

not required as per team discussion

@SutarPrasad SutarPrasad closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gareth-j gareth-j Awaiting requested review from gareth-j

Assignees

@SutarPrasad SutarPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tabs and styling to the sidebar and padding to FAQ
2 participants
@SutarPrasad @gareth-j