Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization in results data #50

Open
davipo opened this issue Feb 16, 2019 · 3 comments
Open

Fix capitalization in results data #50

davipo opened this issue Feb 16, 2019 · 3 comments

Comments

@davipo
Copy link
Contributor

davipo commented Feb 16, 2019

Currently we titlecase all text fields (county, office, ward, candidate). This corrupts many spellings:
county: Fond du Lac
ward: McFarland, McKinley, Prairie du Sac, Prairie du Chien, Fond du Lac, ...
candidate: McCain, de Felice, VanDierendonck, LaDuke, FitzGerald, MaryAnn, "Ben Olson, III", ...

Our test data also has inconsistent capitalization. Current test code titlecases test data before comparing to results. When results capitalization is corrected, titlecasing should be removed, and test data corrected so it tests proper capitalization of results.

@davipo
Copy link
Contributor Author

davipo commented Feb 17, 2019

Capitalization is now corrected in candidate and county fields.
Ward looks more difficult.
Capitalization probably not important in office field. (Titlecase is fine, though "of" could be lower case.)

@davipo
Copy link
Contributor Author

davipo commented Apr 13, 2019

Lowercased "of" in office names. (Updated tests, and run_spot_tests.py to not titlecase them.)
(Commit 4d44d34)

@davipo
Copy link
Contributor Author

davipo commented May 15, 2019

Ward is now the only field with undesirable capitalization. The results ward data is titlecased (wrong for some locales listed above). The capitalization of ward in the current test data is inconsistent, so run_spot_tests.py titlecases it before searching results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant