Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: allow-modals in playground #2987

Conversation

brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented Jan 5, 2024

Description

Resolves #2794

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2b4b4bc
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/659836d25441360008827d38
😎 Deploy Preview https://deploy-preview-2987--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6927788) 93.00% compared to head (2b4b4bc) 93.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2987   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files         236      236           
  Lines        4273     4273           
  Branches     1033     1033           
=======================================
  Hits         3974     3974           
  Misses        295      295           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a heads up that the commit prefix can probably be docs here given this only affects the documentation website and doesn't need to trigger an NPM release.

@brian-smith-tcril brian-smith-tcril changed the title fix: allow-modals in playground docs: allow-modals in playground May 1, 2024
@brian-smith-tcril brian-smith-tcril merged commit 34eef18 into openedx:master May 2, 2024
10 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 22.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Playground] Ignored call to 'alert()'. The document is sandboxed, and the 'allow-modals' keyword is not set.
3 participants