DataTable's "Select all..." label in BaseSelectionStatus shows incorrect counts

[adamstankiewicz]

Bugs

There appears to be a bug/regression related to DataTable and the "Select all" label in the BaseSelectionStatus component, introduced by this PR, which seemed to separately resolve a different bug.

As seen on the Paragon documentation site, when selecting a row using the DataTable.ControlledSelect* sub-components, the "Select all..." label incorrectly says "Select all 3" when there are 7 rows total.

I believe the issue is related to this line:

const filteredItems = filteredRows?.length || itemCount;

It appears that even without any filters applied, filteredRows comes back with an array containing the rows for current page, preventing the itemCount from being shown.

Adjusting the logic to include hasAppliedFilters resolves this particular issue:

const filteredItems = (hasAppliedFilters && filteredRows?.length) || itemCount;

However, it does appear that when a filter is applied, the "Select all..." count is still not quite correct when using the DataTable.ControlledSelect* components. For example, this below table has 60 rows total without any filters ("Select all 60" ✅ ); with a filter applied for "Status" column, there are now 55 rows total (itemCount) but it would state "Select all 25" ⛔ (since the visible page has 25 rows):

Tasks

Preview Give feedback

1. When using the DataTable.ControlledSelect* subcomponents, ensure that when no filters are applied, the "Select all..." label contains the itemCount for the DataTable. It should indicate the total number of rows across the entire table.
2. When using the DataTable.ControlledSelect* subcomponents, ensure that when there are filters applied, the "Select all..." label still contains the itemCount for the table.
3. When using the default DataTable subcomponents, ensure that when no filters are applied, the "Select all..." label contains the itemCount for the DataTable. It should indicate the total number of rows across the entire table.
4. When using the default DataTable subcomponents, ensure that when there are filters applied, the "Select all..." label contains the total number of filteredRows across all pages.

[PKulkoRaccoonGang]

PR: #2929