Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[paragon-openedx.netlify.app] The total number of elements in the DataTable component is incorrect #2843

Closed
2 tasks
PKulkoRaccoonGang opened this issue Nov 23, 2023 · 2 comments · Fixed by #2917
Closed
2 tasks

[paragon-openedx.netlify.app] The total number of elements in the DataTable component is incorrect #2843

PKulkoRaccoonGang opened this issue Nov 23, 2023 · 2 comments · Fixed by #2917
Labels
bug Report of or fix for something that isn't working as intended docs raccoon-gang

Comments

@PKulkoRaccoonGang
Copy link
Contributor

PKulkoRaccoonGang commented Nov 23, 2023 •
edited
Loading

In the example With a default active state specified of the DataTable component, we have a total number of elements equal to 7, but in fact, there are 3.

image

Tasks
Preview Give feedback
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [paragon-openedx.netlify.app] Feedback (on /components/datatable/) [paragon-openedx.netlify.app] The total number of elements in the DataTable component is incorrect. Nov 23, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang added bug Report of or fix for something that isn't working as intended raccoon-gang labels Nov 23, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang changed the title [paragon-openedx.netlify.app] The total number of elements in the DataTable component is incorrect. [paragon-openedx.netlify.app] The total number of elements in the DataTable component is incorrect Nov 23, 2023
@brian-smith-tcril
Copy link
Contributor

I think the 7 in that example is coming from here

paragon/src/DataTable/README.md

Line 439 in 3698605

itemCount={7}

@PKulkoRaccoonGang
Copy link
Contributor Author

PR: #2917

@PKulkoRaccoonGang PKulkoRaccoonGang mentioned this issue Dec 11, 2023
Merged
10 tasks
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from To Do to In progress in Paragon Working Group Dec 11, 2023
@PKulkoRaccoonGang PKulkoRaccoonGang moved this from In progress to In review in Paragon Working Group Dec 11, 2023
@viktorrusakov viktorrusakov linked a pull request Dec 11, 2023 that will close this issue
[BD-46] docs: fixed itemCount in the DataTable code example #2917
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from In review to Done in Paragon Working Group Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Report of or fix for something that isn't working as intended docs raccoon-gang
Projects
Paragon Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BD-46] docs: fixed itemCount in the DataTable code example raccoongang/paragon
2 participants
@PKulkoRaccoonGang @brian-smith-tcril