-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BD-46] refactor: removed unused SCSS variables #2817
[BD-46] refactor: removed unused SCSS variables #2817
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
a0b224b
to
7442879
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2817 +/- ##
==========================================
- Coverage 92.89% 92.83% -0.07%
==========================================
Files 235 235
Lines 4333 4240 -93
Branches 1053 1029 -24
==========================================
- Hits 4025 3936 -89
+ Misses 304 300 -4
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Only concern here that the variables can be used on the user's side. But anyway I prefer to remove them and assume that users don't use them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with github search and I don't see any of these variables used in any of openedx
org's repos, also brand-edx.org does not use them, so it should be safe to delete them.
@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 21.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist